Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: fix execa import in get-report-message #19913

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Maintenance: fix execa import in get-report-message #19913

merged 1 commit into from
Nov 22, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 21, 2022

Issue: N/A

What I did

The change in execa version broke the mechanism that generates report messages:

image

This PR fixes that

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Nov 21, 2022
@yannbf yannbf requested a review from tmeasday November 22, 2022 05:38
tmeasday
tmeasday approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@yannbf yannbf merged commit 52c879a into next Nov 22, 2022
@yannbf yannbf deleted the fix/execa-issues branch November 22, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @tmeasday